Changes for dataset swap callback #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarayan21
reviewed
Oct 4, 2024
snarayan21
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 2.4 upgrade for DCP on pytorch, it flattens all state dict elements which are instances of typing.Mapping or lists before saving. However, during loading, we are expected either Mapping / lists, instead of flattened elements for the runs. This is leading to errors, for eg: initial run
134m-draft-10tpr-train-BNMzsmand follow-up run134m-draft-cl-10tpr-train-7ecT7Q.a quick workaround is to make the statedict as a dataclass, so that it does not get traversed (ie, flattened). Runs with fixes enabled here: initial run
134m-draft-10tpr-train-12VvIxand follow-up run134m-cl-draft-10tpr-train-7fsU4r.