Align logged attributes for errors and run metadata in kill_loss_spike_callback.py #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joyce-chen-uni
commented
Aug 28, 2024
joyce-chen-uni
commented
- Log loss spike/high loss metrics instead of message to run metadata (message will be reconstructed in mapi)
- Only log to run metadata if log_only to avoid duplication of message in train_updated event and failed_exception event
- Add loss_window to error attributes
…ata if log_only, add loss_window to error attributes
joyce-chen-uni
changed the title
joyce-chen-uni
changed the title
joyce-chen-uni
force-pushed
the
joyce/update-metadata-logging
branch
from
0467865 to
56891fc
Compare
dakinggg
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.