Bump composer to 0.24.1 + FSDP config device_mesh deprecation #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvpatel2000 nah I haven't cut the newest composer release yet. I mean this PR can wait until then, but taking out device mesh completely is 0.24.0 onwards |
dakinggg
reviewed
Aug 27, 2024
|
@mvpatel2000 @dakinggg composer v0.24.1 is out so updated this PR. should be good to go |
snarayan21
changed the title
dakinggg
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump composer to 0.24.1, and as part of that, we replace parts of code that assume
device_meshis a key specified in the fsdp_config dict.Added unit test for correct fsdp_config --> ffn_config device mesh parsing
This also resolves issues we were seeing with not using device mesh in regression tests.
Successfully reran failing regressions, which succeeded.