Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable QuickGelu Function for CLIP models #1408

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Enable QuickGelu Function for CLIP models #1408

merged 5 commits into from
Jul 29, 2024

Conversation

gupta-abhay
Copy link
Contributor

  • CLIP Models need the quick_gelu activation function
  • Sourcing from HF, but implemented as Callable for resolve_fn semantics

@gupta-abhay gupta-abhay requested a review from a team as a code owner July 29, 2024 19:23
dakinggg
dakinggg reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a simple unit test that exercises this code path?

@gupta-abhay
Copy link
Contributor Author

@dakinggg - added something, not sure if this is what you had in mind.

@dakinggg
Copy link
Collaborator

@gupta-abhay thats much more than what i meant :D but no objection. left one comment, which is what I actually meant

@gupta-abhay gupta-abhay enabled auto-merge (squash) July 29, 2024 23:22
@gupta-abhay gupta-abhay merged commit 7a7f6df into main Jul 29, 2024
9 checks passed
@dakinggg dakinggg deleted the abhay/gelu_act branch August 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gupta-abhay @dakinggg