-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kushalkodnad/tokenizer-registry] Introduce new registry for tokenizers #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do?
The purpose of this PR is to introduce a new registry, specifically for tokenizers. This way, in the
llmfoudry/utils/builders.py
build_tokenizer()
method, we can build a tokenizer from the registry, as long as the tokenizer inherits thetransformers.PreTrainedTokenizerBase
interface. For instance, the existingTiktokenTokenizerWrapper
inllmfoundry/tokenizers/tiktoken.py
can be built from this registry, as opposed to using if-else clauses inbuild_tokenizer
, which can become tedious if we add support for more tokenizers.File-Specific Changes
llmfoundry/registry.py
This is where I created the
tokenizers
registry. See the brief description of the llmfoundry tokenizers registry, defined in_tokenizers_description
. Then, I followed thecallbacks
registry creation to do the same thing fortokenizers
when callingcreate_registry
.llmfoundry/utils/builders.py
The main idea is to replace the if-else clause that currently supports "tiktoken". As long as the tokenizer is a sub-class of
transformers.PreTrainedTokenizerBase
, then the tokenizer will be constructed.llmfoundry/tokenizers/__init__.py
Following the
callbacks
example, the addition to this file shows how to register atransformers.PreTrainedTokenizerBase
sub-class to the tokenizers registry. Here, I registered thetiktoken
tokenizer to the tokenizers registry, because it inherits the same interface.