Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log all extraneous_keys in one go for ease of development #1344

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Log all extraneous_keys in one go for ease of development #1344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f2710c
Log all extraneous_keys in one go for ease of development
josejg Jul 9, 2024
a56d5c6
Merge branch 'main' into extraneous-keys
mvpatel2000 Jul 11, 2024
5c220e4
Merge branch 'main' into extraneous-keys
j316chuck Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llmfoundry/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,9 @@ def make_dataclass_and_log_config(
if 'variables' not in unstructured_config:
unstructured_config['variables'] = {}

for key in extraneous_keys:
if len(extraneous_keys) > 0:
raise ValueError(
f'Unused parameter {key} found in cfg. Please check your yaml to ensure this parameter is necessary. Please place any variables under the `variables` key.',
f'Unused parameters {sorted(extraneous_keys)} found in cfg. Please check your yaml to ensure these parameters are necessary. Please place any variables under the `variables` key.',
)

dataclass_dict_config: DictConfig = om.structured(
Expand Down
Loading