Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax hf hub pin #1314

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Relax hf hub pin #1314

merged 5 commits into from
Jul 1, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Jun 27, 2024

Update the HF hub pin to allow 0.23 with its breaking changes.

snapshot_download now downloads a few extra files for caching, so this PR permits those files.

Manual test 1, dataset from the hub: hf-hub-bump-2-tYn8Hn
Manual test 2, direct jsonl dataset: hf-hub-bump-jsonl-2-eGfVnE

@dakinggg dakinggg marked this pull request as ready for review June 29, 2024 03:48
@dakinggg dakinggg requested review from a team as code owners June 29, 2024 03:48
@dakinggg dakinggg enabled auto-merge (squash) June 29, 2024 03:48
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing thanks for getting to this!!

@dakinggg dakinggg disabled auto-merge July 1, 2024 20:26
@dakinggg dakinggg merged commit 62165de into mosaicml:main Jul 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants