Error if metadata matches existing keys #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we prefix |
|
looks good to me, but I'll give it a try just in case |
irenedea
approved these changes
Jul 1, 2024
Co-authored-by: Irene Dea <[email protected]>
irenedea
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We flatten the metadata so that it is easier to parse out of mlflow/run metadata. Because of this, a user's metadata key could overwrite the real key in the config that gets logged. This PR fixes that by simple erroring and asking the user to rename their metadata key. It also adds
flatten_metadatato allow not flattening the metadata.Original run that overwrites the key:
metadata-with-error-4-G9ps3TRun with duplicate key that now errors:
metadata-unflat-1-ltIBGLRun without flattening metadata:
metadata-unflat-2-VoxpxS