Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Composer to 0.23.0 #1259

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Bump Composer to 0.23.0 #1259

merged 6 commits into from
Jun 6, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Jun 6, 2024

No description provided.

@KuuCi KuuCi marked this pull request as ready for review June 6, 2024 22:07
@KuuCi KuuCi requested review from a team as code owners June 6, 2024 22:07
@KuuCi
Copy link
Contributor Author

KuuCi commented Jun 6, 2024

(almost) working reg test:
mcli logs -f llm-foundry-regression-tests-runner-5L8OVq

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make a jira to deprecate fsdp_config as a foundry arg and replace it in all the tests?

@dakinggg dakinggg merged commit 14f296c into main Jun 6, 2024
9 checks passed
KuuCi added a commit that referenced this pull request Jun 7, 2024
(cherry picked from commit 14f296c)
KuuCi added a commit that referenced this pull request Jun 7, 2024
KuuCi added a commit that referenced this pull request Jun 7, 2024
dakinggg added a commit to dakinggg/llm-foundry that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants