-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the publicly exported API #1128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add the trailng commas thing? @b-chu has instructions (reisort)
Is there a way to automate fixing the all? I think that type of debt will accumulate and require future PRs like this if there's no pre-commit hook for it |
For trailing commas, this is the relevant change to pyproject.toml |
@mvpatel2000 Brian said it wasn't as simple as just changing the pyproject and would take a few hours, so I am not going to include that in this PR @b-chu Not sure if there is a way to automate the alls. Some of the choices of what to reexport are more subjective, but if there is a good way to automate, I'm very open to it. |
Can we prioritize doing this soon? it has frequently come up in PR reviews |
Fixes up a bunch of __all__s