Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the publicly exported API #1128

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Conversation

dakinggg
Copy link
Collaborator

Fixes up a bunch of __all__s

Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add the trailng commas thing? @b-chu has instructions (reisort)

llmfoundry/eval/datasets/__init__.py Show resolved Hide resolved
@b-chu
Copy link
Contributor

b-chu commented Apr 22, 2024

Is there a way to automate fixing the all? I think that type of debt will accumulate and require future PRs like this if there's no pre-commit hook for it

@b-chu
Copy link
Contributor

b-chu commented Apr 22, 2024

@dakinggg
Copy link
Collaborator Author

@mvpatel2000 Brian said it wasn't as simple as just changing the pyproject and would take a few hours, so I am not going to include that in this PR

@b-chu Not sure if there is a way to automate the alls. Some of the choices of what to reexport are more subjective, but if there is a good way to automate, I'm very open to it.

@mvpatel2000
Copy link
Collaborator

@mvpatel2000 Brian said it wasn't as simple as just changing the pyproject and would take a few hours, so I am not going to include that in this PR

Can we prioritize doing this soon? it has frequently come up in PR reviews

@dakinggg dakinggg merged commit 4952183 into mosaicml:main Apr 22, 2024
9 checks passed
@dakinggg dakinggg deleted the public-api branch June 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants