Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for subclasses to convert model and tokenizer in hf checkpointer #1121

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Add option for subclasses to convert model and tokenizer in hf checkpointer #1121

merged 3 commits into from
Apr 19, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Apr 19, 2024 •
edited
Loading

This will allow subclasses of the hf checkpointer to apply an arbitrary transformation to the model and tokenizer before saving.

@dakinggg dakinggg marked this pull request as ready for review April 19, 2024 02:58
mvpatel2000
mvpatel2000 reviewed Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR descriptions are your friend. Please write one and then I will review :P

irenedea
irenedea approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg dakinggg enabled auto-merge (squash) April 19, 2024 17:08
@dakinggg dakinggg merged commit 63a7f12 into mosaicml:main Apr 19, 2024
10 checks passed
@dakinggg dakinggg deleted the hf-checkpointer-modular branch June 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@irenedea irenedea irenedea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @irenedea @mvpatel2000