Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiktoken vocab size #1081

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Apr 2, 2024

The vocab size incorrectly did not include added tokens.

@dakinggg dakinggg marked this pull request as ready for review April 2, 2024 07:38
@dakinggg dakinggg merged commit caf7fda into mosaicml:main Apr 2, 2024
9 checks passed
dakinggg added a commit to dakinggg/llm-foundry that referenced this pull request Apr 4, 2024
* fix vocab size bug

* more tests
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
* fix vocab size bug

* more tests
@dakinggg dakinggg deleted the fix-tiktoken-vocab-size branch June 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants