Norms registry #1080
Merged
Norms registry #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
force-pushed
the
layers-registry
branch
from
4adb96d
to
1aa7109
Compare
This was referenced Apr 4, 2024
Merged
Merged
Merged
irenedea
reviewed
Apr 4, 2024
mvpatel2000
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the layers part of the registry with just the norms so we can review the overall setup of the layers registry in a smaller PR.
Note: In order to get the type checker to be happy with the decorator version of registering classes, I had to add a
register_classmethod with more scoped typing. Open to other suggestions for how to accomplish this.Also manually tested that the hf checkpoint saved can be loaded back in with
AutoModelForCausalLM