Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluators actually pulling eval metrics #1006

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Fix evaluators actually pulling eval metrics #1006

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3b3a61
fix bug on metrics
mvpatel2000 Mar 2, 2024
4d9e6c9
lint
mvpatel2000 Mar 2, 2024
1ecd22c
lint
mvpatel2000 Mar 2, 2024
76e6556
Merge branch 'main' into mvpatel2000/fix-eval-metrics
mvpatel2000 Mar 4, 2024
eeba10f
add unit test
mvpatel2000 Mar 4, 2024
e832201
lint
mvpatel2000 Mar 4, 2024
64d6163
Merge branch 'main' into mvpatel2000/fix-eval-metrics
mvpatel2000 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions scripts/train/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from composer.loggers import MosaicMLLogger
from composer.loggers.mosaicml_logger import (MOSAICML_ACCESS_TOKEN_ENV_VAR,
MOSAICML_PLATFORM_ENV_VAR)
from composer.metrics.nlp import InContextLearningMetric
from composer.profiler import (JSONTraceHandler, Profiler, TraceHandler,
cyclic_schedule)
from composer.utils import dist, get_device, reproducibility
Expand Down Expand Up @@ -534,9 +535,12 @@ def main(cfg: DictConfig) -> Trainer:

# Now add the eval metrics
if eval_loader_config is not None and not use_async_eval:
train_metrics = model.get_metrics(is_train=True)
evaluators = add_metrics_to_eval_loaders(evaluators,
list(train_metrics.keys()))
eval_metrics = model.get_metrics(is_train=False)
non_icl_metrics = [
metric_name for metric_name, metric in eval_metrics.items()
if not isinstance(metric, InContextLearningMetric)
]
evaluators = add_metrics_to_eval_loaders(evaluators, non_icl_metrics)

# Build the Trainer
log.info('Building trainer...')
Expand Down
Loading