Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deepspeed completely #3732

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Remove deepspeed completely #3732

merged 11 commits into from
Dec 3, 2024

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

Removes anything and everything from Composer related to Deepspeed. Support for deepspeed should have been deprecated in v0.27.0, so doing this now.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested review from a team as code owners December 3, 2024 16:25
@snarayan21 snarayan21 requested a review from bigning December 3, 2024 16:32
mvpatel2000
mvpatel2000 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

composer/loggers/wandb_logger.py Outdated Show resolved Hide resolved
tests/algorithms/test_sam.py Outdated Show resolved Hide resolved
tests/algorithms/test_sam.py Outdated Show resolved Hide resolved
@mvpatel2000
Copy link
Contributor

Please make sure to git grep to verify it has been removed

dakinggg
dakinggg reviewed Dec 3, 2024
View reviewed changes
composer/callbacks/checkpoint_saver.py Outdated Show resolved Hide resolved
composer/callbacks/checkpoint_saver.py Outdated Show resolved Hide resolved
composer/trainer/trainer.py Outdated Show resolved Hide resolved
@snarayan21 snarayan21 merged commit 06a5f31 into main Dec 3, 2024
14 checks passed
@snarayan21 snarayan21 deleted the saaketh/remove_deepspeed branch December 3, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg left review comments

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@bigning bigning Awaiting requested review from bigning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snarayan21 @mvpatel2000 @dakinggg