Code

remove orig_params check#2981

Code

Merged

milocress merged 67 commits intomosaicml:devmosaicml/composer:devfrom milocress:milo/remove-orig-params-checkmilocress/composer:milo/remove-orig-params-checkCopy head branch name to clipboardMay 16, 2024

+83-108

Commits

Commits on Feb 8, 2024

• remove orig_params check

  milocress

  committed
  b276016

Commits on Feb 14, 2024

• expect cpu-cpu test to fail

  milocress

  committed
  c9fea5d

• expect cpu-cpu test to fail

  milocress

  committed
  13ccb2b

• fix formatting

  milocress

  committed
  3139b5c

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  03cbf4a

Commits on Feb 29, 2024

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  412a672

Commits on Mar 19, 2024

• Update test_checkpoint.py

  milocress

  authored
  aea6ebd

Commits on Mar 20, 2024

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  8d65cfb

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  0fe6c1f

• expect True,True to succeed?

  milocress

  committed
  faf8c71

• remove commented code

  milocress

  committed
  0939597

• rerun tests

  mvpatel2000

  committed
  80f79dc

• how about now

  milocress

  committed
  f483dfb

• updated tests

  milocress

  committed
  7ccac42

• fix tests

  milocress

  committed
  a01c954

Commits on Mar 21, 2024

• Update test_checkpoint.py

  milocress

  authored
  ca3929f

Commits on Apr 3, 2024

• WIP debugging

  milocress

  committed
  dd7583c

• merged

  milocress

  committed
  3da6a5f

Commits on Apr 9, 2024

• wip debug

  milocress

  committed
  469f31a

Commits on Apr 12, 2024

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  34ba1bd

Commits on May 2, 2024

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  bd71a66

• Update test_checkpoint.py

  milocress

  authored
  b6eea9c

• Update test_checkpoint.py

  milocress

  authored
  6a8ff28

• Update test_checkpoint.py

  milocress

  authored
  43aa2d4

• Update test_checkpoint.py

  milocress

  authored
  7de12a2

• Update test_checkpoint.py

  milocress

  authored
  a38348f

• Update test_checkpoint.py

  milocress

  authored
  b567fa9

Commits on May 7, 2024

• WIP

  milocress

  committed
  072844f

• Merge branch 'dev' into milo/remove-orig-params-check

  mvpatel2000

  authored
  3ba9215

Commits on May 13, 2024

• counterexample is hanging guh

  milocress

  committed
  7db4478

• merged

  milocress

  committed
  6e73f60

• have repro

  milocress

  committed
  2038088

• less composer repro

  milocress

  committed
  9945aaf

• found bug

  milocress

  committed
  46c87b8

Commits on May 14, 2024

• make counterexample match composer wrapper model situation

  milocress

  committed
  d7c9879

• still doesn't work

  milocress

  committed
  3c28db9

• update counterexample with printed models to show they're wrappped the same

  milocress

  committed
  8e1457e

• trim unnecessary stuff

  milocress

  committed
  d80d9da

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  5624b47

• counterexample for the record

  milocress

  committed
  a37962d

• simplified counterexample

  milocress

  committed
  fdb681b

• fix tests

  milocress

  committed
  e983170

• fix quality and delete counterexample

  milocress

  committed
  9789245

• fix

  milocress

  committed
  b213b92

• asdict

  milocress

  committed
  79fbed0

• remove self (lol if only)

  milocress

  committed
  cea4402

• fix test

  milocress

  committed
  01d18fa

• fix fix

  milocress

  committed
  9eb1a35

Commits on May 15, 2024

• fix

  milocress

  committed
  4b430a8

• reset save folder changes

  milocress

  committed
  2d6aea9

• remove meta for now

  milocress

  committed
  37031b7

• replace load_monolith_ with load_fsdp_monolith_

  milocress

  committed
  049158f

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  b477bc3

• change load_fsdp_monolith_rank0_only to load_monolith_rank0_only

  milocress

  committed
  1c7d3c2

• merged fsdp change

  milocress

  committed
  6e0eac0

• resolve conflicts?

  milocress

  committed
  4507db1

• expect failure when no sync module states

  milocress

  committed
  33e007f

• fix constructor()

  milocress

  committed
  a70e852

• WIP

  milocress

  committed
  aba4387

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  44e6f7f

Commits on May 16, 2024

• WIP

  milocress

  committed
  eb186f2

• merged

  milocress

  committed
  73e97b7

• Update test_fsdp_checkpoint.py

  mvpatel2000

  authored
  40dc38b

• make PR ready for review

  milocress

  committed
  115156a

• Merge branch 'dev' into milo/remove-orig-params-check

  milocress

  authored
  c2d8b66

• remove device

  milocress

  committed
  cddb4c1

• merged

  milocress

  committed
  e1b7439