Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a BEFORE_LOAD event #2974

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

Adds a BEFORE_LOAD event that callbacks can use, that happens right before the checkpoint gets loaded. This more easily enables different functions like saving checkpoints from a fully initialized model + optimizer immediately, or changing the dataset state once the dataloader has been passed to the State object.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested a review from a team as a code owner February 7, 2024 21:21
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will leave approval for mihir

@snarayan21 snarayan21 merged commit 07d53e0 into mosaicml:dev Feb 7, 2024
15 checks passed
mvpatel2000 added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants