-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ffcv up in test order #1953
Conversation
Can we fix the ones failing rn that are deterministically failing first? |
ce905b3
to
6dcd8ee
Compare
ffcv test is not deterministically failing for me. It passes on local run. |
So, I agree with the sentiment of this change, but I'm a little worried that we may have a number of non deterministic issues and will spend a significant amount of time debugging them on unrelated PRs. Is there any way we can de risk that? Like, should someone spend a few days just trying different random orders and fixing anything that pops up? |
@dakinggg we don't have to merge this now but eventually do something like this to make testing more robust. Currently I want to see if the test_ffcv failure goes away with this. |
Sounds good 👍 |
BTW this is more one time effort than ongoing effort. |
Absolutely :) |
6dcd8ee
to
549d396
Compare
Ignore any updates to this PR. This is just to fix the failing test. |
e137b00
to
40c477f
Compare
40c477f
to
4f3bff9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super bizarre but LGTM.
What does this PR do?
Randomize the order of pytest to catch errors that may work if the tests are run in the same order.Move the test up in order so that it passes. Don't ask me why!!