Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

A bug fix and some efficiency upgrade #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Xesenix
Copy link

@Xesenix Xesenix commented May 22, 2015

I found a bug when running multiple instances of appear for example something like this

$('.selector1').appear({force_process: true})
.on('appear', function() {
    console.log('hi 1');
})
.on('disappear', function() {
    console.log('bye 1');
});

$('.selector2').appear({force_process: true})
.on('appear', function() {
    console.log('hi 2');
})
.on('disappear', function() {
    console.log('bye 2');
});

when scrolled and both selector where visible disappear was triggered for both selectors.

Second fix is for disabling running appear event for elements for which it was already fired.

Xesenix added 2 commits May 22, 2015 03:52
when running multiple instances disapear event was triggered on visible
elements
apear event was triggered on already apeared elements
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant