refactor(test): revert renaming #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
Tristan22400,
MerlinEgalite,
pakim249CAL and
makcandrov
MerlinEgalite
previously approved these changes
Jun 22, 2023
Tristan22400
previously approved these changes
Jun 22, 2023
pakim249CAL
previously approved these changes
Jun 22, 2023
fix: remove delegator fuzz
MerlinEgalite
dismissed stale reviews from pakim249CAL, Tristan22400, and themself
via
24efe27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue(s) fixed
This pull request:
This PR also highlights that
_boundAddressNotZerowas also renamed to_boundAddressNotInvalidin internal tests, which don't inherit fromIntegrationTest, making the dev believe the behavior was blacklisting specific failing addresses whereas it's just discarding the zero address input