Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](parquet-reader) some fix for #5 (Fix and optimize parquet min-max filtering). #6

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Fix](parquet-reader) some fix for #5 (Fix and optimize parquet min-max filtering). #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions be/src/vec/exec/format/parquet/parquet_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,16 +437,16 @@ class CorruptStatistics {
private:
static void warn_parse_error_once(const std::string& createdBy, const std::string_view& msg) {
//if (!already_logged.exchange(true)) {
LOG(WARNING) << "Ignoring statistics because created_by could not be parsed (see "
"PARQUET-251)."
" CreatedBy: "
<< createdBy << ", msg: " << msg;
LOG(WARNING) << "Ignoring statistics because created_by could not be parsed (see "
"PARQUET-251)."
" CreatedBy: "
<< createdBy << ", msg: " << msg;
//}
}

static void warn_once(const std::string_view& msg) {
//if (!already_logged.exchange(true)) {
LOG(WARNING) << msg;
LOG(WARNING) << msg;
//}
}

Expand Down
12 changes: 7 additions & 5 deletions be/src/vec/exec/format/parquet/parquet_pred_cmp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ class ParquetPredicate {

CppType min_value;
CppType max_value;
std::unique_ptr<std::string> encoded_min_copy;
std::unique_ptr<std::string> encoded_max_copy;
tparquet::Type::type physical_type = col_schema->physical_type;
switch (col_val_range.type()) {
#define DISPATCH(REINTERPRET_TYPE, PARQUET_TYPE) \
Expand Down Expand Up @@ -186,13 +188,13 @@ class ParquetPredicate {
case TYPE_STRING:
if constexpr (std::is_same_v<CppType, StringRef>) {
if (!use_min_max_value) {
std::string min_copy(encoded_min);
std::string max_copy(encoded_max);
if (!_try_read_old_utf8_stats(min_copy, max_copy)) {
encoded_min_copy = std::make_unique<std::string>(encoded_min);
encoded_max_copy = std::make_unique<std::string>(encoded_max);
if (!_try_read_old_utf8_stats(*encoded_min_copy, *encoded_max_copy)) {
return false;
}
min_value = StringRef(min_copy);
max_value = StringRef(max_copy);
min_value = StringRef(*encoded_min_copy);
max_value = StringRef(*encoded_max_copy);
} else {
min_value = StringRef(encoded_min);
max_value = StringRef(encoded_max);
Expand Down
Loading