Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost 1.67: Android < 21 builds Error Since pthread_condattr_setclock is Called When Method is Only Avaliable in Android >= 21 #132

Closed
epicstar opened this issue Apr 27, 2018 · 1 comment

Comments

@epicstar
Copy link
Contributor

epicstar commented Apr 27, 2018

Essentially, I'm unable to fully build the Boost 1.67 libraries for armeabi-v7a and x86. This is very easy to reproduce for me.... All I had to do is run the following on the latest master branch with r16b and 15 seconds into the compilation step, it errored:

./build-android.sh $ANDROID_NDK_ROOT --toolchain=llvm --arch=armeabi-v7a

The fix is easy, which is just to change a couple lines in thread/detail/config.hpp to not call pthread_condattr_setclock. @gjasny has already provided a patch for this specific issue in 1.67 and fixed it in 1.68. Full details here explained here: boostorg/thread#215

After adding this patch to the code along with the existing code, I was able to compile all libraries on armeabi-v7a and x86 on Android API 19.

I'm going to create a pull request with a new patch file for 1.67 that includes this fix. I'll link the merge request ASAP.

@epicstar epicstar changed the title Boost 1.67: Android < 21 builds Crash Since pthread_condattr_setclock is Called Since Method is Available in Android >= 21 Boost 1.67: Android < 21 builds Error Since pthread_condattr_setclock is Called When Method is Only Avaliable in Android >= 21 Apr 27, 2018
epicstar pushed a commit to MModal/Boost-for-Android that referenced this issue Apr 27, 2018
@pelya
Copy link
Collaborator

pelya commented May 30, 2018

Probably fixed, I did not test the patch.

@pelya pelya closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants