Moban extension #61
Merged
Moban extension #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… engine class would have equal access to plugin registry
…d non-function payload. this is something that lml should consider to support them seamlessly.
… module names. python does not import duplicated modules
Codecov Report
@@ Coverage Diff @@
## dev #61 +/- ##
==========================================
+ Coverage 98.77% 98.89% +0.11%
==========================================
Files 27 32 +5
Lines 1146 1266 +120
==========================================
+ Hits 1132 1252 +120
Misses 14 14
Continue to review full report at Codecov.
|
jayvdb
reviewed
Jun 9, 2018
| targets: | ||
| - filter.output: filter.jj2 | ||
| - test.output: test.jj2 | ||
| - global.output: global.jj2 |
| Everything is up to date! | ||
|
|
||
| Please examine individual template and its associated plugin for more details. | ||
|
|
| Hello, you are in level 7 example | ||
| {% else %} | ||
| Hello, you are not in level 7 | ||
| {% endif %} |
| {%else%} | ||
| no | ||
| {% endif %} | ||
| {{ test }} |
chfw
added a commit
that referenced
this pull request
Jun 9, 2018
chfw
added a commit
that referenced
this pull request
Jun 11, 2018
* ✨ choose a template based on its file extension. fix #43 * 📚 update change log * 🐛 fix the template names * 📚 udpate readme * ✨ default template engine will be jinja2 if template type(file extension) cannot be found * 👕 address review feedback. #61 * 🎨 keep cli --template_type option * ✨ allow template_type in moban file to indicate default template engine. i.e. if unknown template type(file suffix) is found, the default template engine is used. So if mako engine is specified via template_type, an unknown template file such as strange.template will be rendered by mako engine * ✨ allow jinja2 become template suffix too, meaning a.jj2 and b.jinja2 will be rendered by the same engine. however, for now, the engine instance will not be the same. later on, this can be consolidated * 📚 update change log. #58 * ✨ associate jinja2 engine with more file types, j2, jinja and retore the default template engine name as jinja2 * 📚 documentation update
chfw
added a commit
to moremoban/moban-handlebars
that referenced
this pull request
Nov 18, 2018
* ✨ choose a template based on its file extension. fix #43 * 📚 update change log * 🐛 fix the template names * 📚 udpate readme * ✨ default template engine will be jinja2 if template type(file extension) cannot be found * 👕 address review feedback. moremoban/moban#61 * 🎨 keep cli --template_type option * ✨ allow template_type in moban file to indicate default template engine. i.e. if unknown template type(file suffix) is found, the default template engine is used. So if mako engine is specified via template_type, an unknown template file such as strange.template will be rendered by mako engine * ✨ allow jinja2 become template suffix too, meaning a.jj2 and b.jinja2 will be rendered by the same engine. however, for now, the engine instance will not be the same. later on, this can be consolidated * 📚 update change log. #58 * ✨ associate jinja2 engine with more file types, j2, jinja and retore the default template engine name as jinja2 * 📚 documentation update
chfw
added a commit
to moremoban/moban-handlebars
that referenced
this pull request
Nov 18, 2018
* ✨ choose a template based on its file extension. fix #43 * 📚 update change log * 🐛 fix the template names * 📚 udpate readme * ✨ default template engine will be jinja2 if template type(file extension) cannot be found * 👕 address review feedback. moremoban/moban#61 * 🎨 keep cli --template_type option * ✨ allow template_type in moban file to indicate default template engine. i.e. if unknown template type(file suffix) is found, the default template engine is used. So if mako engine is specified via template_type, an unknown template file such as strange.template will be rendered by mako engine * ✨ allow jinja2 become template suffix too, meaning a.jj2 and b.jinja2 will be rendered by the same engine. however, for now, the engine instance will not be the same. later on, this can be consolidated * 📚 update change log. #58 * ✨ associate jinja2 engine with more file types, j2, jinja and retore the default template engine name as jinja2 * 📚 documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivers solution for the following issues:
#23
#18
#26