-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.6.0 - PyFileSystem2 support #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 does not like **
🔨 replace os.path in moban files 🔥 remove one more os line
* 📚 update level 10 moban dependency as git repo. we will use gitfs2 from moremoban * 🚜 relocate files * 🔥 remove repo file system openner 🚜 relocate old code to deprecated * 👕 update coding style * 💚 fix unit test import * 🚜 relocate deprecated code to deprecated folder and will start remove later * 👕 pass moban_command check * 👕 update coding style * 📚 add any location to our vision * 🔥 remove pypi requires from moban. pypifs takes care of it now. * 🚜 relocated the pip_install code to deprecated folder. ready for future clean up * 🔬 level 21 can read from tar too * 🔬 test copy from a tar * 👕 update coding style * 🔥 remove useless test fixtures * 📚 update regresssion test readme 📚 update level 9 and 10 docs about packages required to support * 📚 update diagram command * 📚 update architecture diagram
* 🔥 remove appdirs and gitpython from moban dependency list * 📚 add a use case: template from a s3 bucket * ✨ add -d for development tracing. fix #185 * 🚜 do not log the exception but as info * 📚 update documenation * 🐛 moban -t url -c url -o moban.output failes * 🔬 more tests * 👕 fix format * 📚 update change log and readme * 🔥 remove unused imports * 🔬 more tests * 👕 fix coding style * 📚 update package url link * 💚 make travis tests pass * 💚 make windows tests pass. an osfs was passed to multifs and the invalid characters on windows are different from the ones on linx. hence pypifs and gitfs2 url are seen as invalid on windows. PyFilesystem/pyfilesystem2#347 * 🔥 remove adapter folder * 🐛 fix build failure on opensuse. resolves #275 * ✨ use released version of pypifs * 📰 add pypifs as test dependency
* 🔥 use released version gitfs2 for testing * 🔨 code restructuring * 🔨 split plugins folder to plugins.py and core * 🚜 relocate deprecated code to deprecated folder for easy future removal * 👕 update coding style * 🚜 rename template to moban_factory for better readability * 👕 update coding style * 🚜 relocate deprecated code for future removal
* 🔨 🚜 refactored tests * 📚 enhanced PR template * 👕 🚜 beautify the test codes * 🔨 code refactoring on test docs * 🔨 fully transform the docs based tests * 🔬 test assertions for level 21 * 👕 coding style update * 🔥 deduplication
* 👕 minor update * 🔨 use multi_fs instance to iterate file instead of an independent file system instance * ♿ more logging and improve code coherence * 🚜 update code coherence
* 🐛 update templated count * 🐛 fix a typeo
chfw
requested review from
jayvdb,
CLiu13,
PrajwalM2212,
ayan-b,
seeeturtle and
siddhpant
September 9, 2019 16:49
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 98.94% 95.36% -3.58%
==========================================
Files 60 51 -9
Lines 2553 2547 -6
==========================================
- Hits 2526 2429 -97
- Misses 27 118 +91
Continue to review full report at Codecov.
|
May fix: #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before raising the PR, here is a check list:
More details are in change-log.
Depends on fs 2.4.11: PyFilesystem/pyfilesystem2#330