Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 json data shall override environment data too #153

Merged
merged 5 commits into from
Jan 6, 2019
Merged

🐛 json data shall override environment data too #153

merged 5 commits into from
Jan 6, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Jan 6, 2019

@codecov-io
Copy link

codecov-io commented Jan 6, 2019 •
edited
Loading

Codecov Report

Merging #153 into dev will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #153      +/-   ##
=========================================
+ Coverage   97.9%   98.02%   +0.11%     
=========================================
  Files         40       40              
  Lines       1957     1970      +13     
=========================================
+ Hits        1916     1931      +15     
+ Misses        41       39       -2
Impacted Files Coverage Δ
tests/test_context.py 100% <100%> (ø) ⬆️
moban/plugins.py 97.91% <100%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea6326...663b1cf. Read the comment docs.

@chfw chfw requested a review from CLiu13 January 6, 2019 13:36
CLiu13
CLiu13 approved these changes Jan 6, 2019
View reviewed changes
Copy link
Collaborator

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chfw chfw merged commit 99bcd21 into dev Jan 6, 2019
@chfw chfw deleted the override-json-data-too branch January 6, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CLiu13 CLiu13 CLiu13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfw @codecov-io @CLiu13