Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binary image updated sensors not working #997

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Fix binary sensors when image is updated from the "no mail" images.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the bugfix Pull request to fix a bug label Nov 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (8608d22) to head (ed2c905).
Report is 40 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #997      +/-   ##
==========================================
- Coverage   95.07%   93.49%   -1.58%     
==========================================
  Files           8        8              
  Lines        1482     1614     +132     
==========================================
+ Hits         1409     1509     +100     
- Misses         73      105      +32     
Files with missing lines Coverage Δ
...stom_components/mail_and_packages/binary_sensor.py 84.21% <100.00%> (-12.98%) ⬇️
custom_components/mail_and_packages/helpers.py 92.94% <100.00%> (-1.79%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 merged commit 10f3817 into moralmunky:dev Nov 13, 2024
5 checks passed
@firstof9 firstof9 deleted the fix-996 branch November 13, 2024 17:08
firstof9 added a commit to firstof9/Home-Assistant-Mail-And-Packages that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants