Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move amazon image clean up to proper function #987

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

firstof9
Copy link
Collaborator

@firstof9 firstof9 commented Nov 1, 2024

Proposed change

Move the amazon image clean up to proper function for cleaning up files.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the bugfix Pull request to fix a bug label Nov 1, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (8608d22) to head (0473009).
Report is 37 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #987      +/-   ##
==========================================
- Coverage   95.07%   94.08%   -1.00%     
==========================================
  Files           8        8              
  Lines        1482     1605     +123     
==========================================
+ Hits         1409     1510     +101     
- Misses         73       95      +22     
Files with missing lines Coverage Δ
custom_components/mail_and_packages/helpers.py 92.86% <100.00%> (-1.86%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review November 1, 2024 21:40
@firstof9 firstof9 merged commit 52340d7 into moralmunky:dev Nov 1, 2024
5 checks passed
@firstof9 firstof9 deleted the fix-amazon-cleanup branch November 1, 2024 21:40
firstof9 added a commit to firstof9/Home-Assistant-Mail-And-Packages that referenced this pull request Dec 19, 2024
* fix: move amazon image clean up to proper function

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants