Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust amazon forwarding validation function #957

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Adjust amazon forwarding email validation function.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the code-quality Improves code quality or adds/updates tests label Jul 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (8608d22) to head (8ef2f61).
Report is 29 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #957      +/-   ##
==========================================
- Coverage   95.07%   93.49%   -1.59%     
==========================================
  Files           8        8              
  Lines        1482     1567      +85     
==========================================
+ Hits         1409     1465      +56     
- Misses         73      102      +29     
Files Coverage Δ
custom_components/mail_and_packages/config_flow.py 93.13% <100.00%> (-6.87%) ⬇️

... and 3 files with indirect coverage changes

@firstof9 firstof9 merged commit 1e8c614 into moralmunky:dev Jul 23, 2024
5 checks passed
@firstof9 firstof9 deleted the amazon_fwds branch July 23, 2024 23:23
firstof9 added a commit to firstof9/Home-Assistant-Mail-And-Packages that referenced this pull request Dec 19, 2024
* refactor: adjust amazon forwarding validation function

* linting, update translations

* add additional test

* use regex when checking for domain

* formatting

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants