Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usps mail delivered binary sensor #922

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Add "USPS Mail Delivered" binary sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the feature New feature or request label Jun 22, 2024
@firstof9 firstof9 linked an issue Jun 22, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.38%. Comparing base (8608d22) to head (42447eb).
Report is 6 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #922      +/-   ##
==========================================
- Coverage   95.07%   94.38%   -0.69%     
==========================================
  Files           8        8              
  Lines        1482     1532      +50     
==========================================
+ Hits         1409     1446      +37     
- Misses         73       86      +13     
Files Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)
custom_components/mail_and_packages/helpers.py 93.08% <ø> (-1.64%) ⬇️
...stom_components/mail_and_packages/binary_sensor.py 95.89% <50.00%> (-1.30%) ⬇️

... and 3 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review June 22, 2024 22:40
@firstof9 firstof9 merged commit 66a146f into moralmunky:dev Jun 22, 2024
5 checks passed
@firstof9 firstof9 deleted the feat-915 branch June 22, 2024 22:40
firstof9 added a commit to firstof9/Home-Assistant-Mail-And-Packages that referenced this pull request Dec 19, 2024
* feat: add usps mail delivered binary sensor

* add logic to binary_sensor

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sensor for delivered USPS mail.
2 participants