Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipper): added Walmart delivering sensor. Added new subject to Walmart delivered. #884

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

skewll
Copy link

@skewll skewll commented Apr 3, 2024

Added Walmart Delivering Sensor

Updated Walmart Delivered Sensor subject array.
Updated Walmart Delivered tracking pattern.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@firstof9 firstof9 changed the title Added Walmart Delivering Sensor. Added new Subject to Walmart Delivered. fix(shipper): added Walmart delivering sensor. Added new subject to Walmart delivered. Apr 3, 2024
@firstof9 firstof9 added bugfix Pull request to fix a bug shipper Request to add/modify a shipper labels Apr 3, 2024
@firstof9
Copy link
Collaborator

firstof9 commented Apr 3, 2024

Just the recommendation and then formatting with black should check all the boxes 👍

@skewll
Copy link
Author

skewll commented Apr 4, 2024

I didn't change the version at all. I'm not sure how that happened. I've pushed a new commit with the suggested version change. I also used Microsoft's black extension. I hope that's the right extension.

@skewll skewll requested a review from firstof9 April 4, 2024 02:23
Copy link
Collaborator

@firstof9 firstof9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (3506995) to head (0133e97).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #884   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files           8        8           
  Lines        1481     1481           
=======================================
  Hits         1409     1409           
  Misses         72       72           
Files Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)

@firstof9
Copy link
Collaborator

firstof9 commented Apr 4, 2024

Thanks!

@firstof9 firstof9 merged commit eec5065 into moralmunky:dev Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug shipper Request to add/modify a shipper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants