Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipper): add dhl more address #862

Merged
merged 9 commits into from
Oct 29, 2023
Merged

Conversation

Jaharmi
Copy link

@Jaharmi Jaharmi commented Oct 28, 2023

Proposed change

Add criteria for DHL shipments. Repeat of #735 after rebasing from “dev” branch.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

This PR fixes issue: #727

@Jaharmi
Copy link
Author

Jaharmi commented Oct 28, 2023

If this is accepted, can it have the HACKTOBERFEST-ACCEPTED label added? I’d like to get credit for Hacktoberfest 2023. Thanks!

@firstof9
Copy link
Collaborator

Looks like you need to run black and it should pass tests.

@firstof9 firstof9 added enhancement Changes that reduce code complexity or speed things up shipper Request to add/modify a shipper labels Oct 29, 2023
@Jaharmi
Copy link
Author

Jaharmi commented Oct 29, 2023

Formatted with Black.

@firstof9 firstof9 changed the title fix: Dhl address fix(shipper): add dhl address Oct 29, 2023
@firstof9 firstof9 changed the title fix(shipper): add dhl address fix(shipper): add dhl more address Oct 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #862 (525bc78) into dev (acbb0d9) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #862   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files           8        8           
  Lines        1508     1508           
=======================================
  Hits         1472     1472           
  Misses         36       36           
Files Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)

@firstof9
Copy link
Collaborator

Thanks!

@firstof9 firstof9 merged commit ce2870d into moralmunky:dev Oct 29, 2023
7 of 8 checks passed
@firstof9
Copy link
Collaborator

Let me know if that counted for hacktoberfest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that reduce code complexity or speed things up HACKTOBERFEST-ACCEPTED shipper Request to add/modify a shipper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants