Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipper): update DHL for Germany #766

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

CHirch
Copy link

@CHirch CHirch commented Dec 9, 2022

Fixed German DHL sensor

Breaking change

none

Proposed change

German DHL sensor did not work. I adjusted the patterns so hopefully it will now detect mails correctly.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • Update existing shipper

fixed DHL de
custom_components/mail_and_packages/const.py Outdated Show resolved Hide resolved
custom_components/mail_and_packages/const.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #766 (da7d3cf) into dev (b1630d4) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #766      +/-   ##
==========================================
+ Coverage   97.14%   97.21%   +0.06%     
==========================================
  Files           6        8       +2     
  Lines        1297     1508     +211     
==========================================
+ Hits         1260     1466     +206     
- Misses         37       42       +5     
Impacted Files Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)
custom_components/mail_and_packages/__init__.py 95.90% <0.00%> (ø)

@CHirch CHirch requested a review from firstof9 December 9, 2022 20:00
@firstof9 firstof9 merged commit 798ff3e into moralmunky:dev Dec 9, 2022
@firstof9
Copy link
Collaborator

firstof9 commented Dec 9, 2022

Thanks!

@firstof9 firstof9 added bugfix Pull request to fix a bug shipper Request to add/modify a shipper labels Dec 9, 2022
@CHirch CHirch deleted the patch-2 branch December 9, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug shipper Request to add/modify a shipper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants