Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust config flow for amazon forwards #693

Merged
merged 2 commits into from
Jul 11, 2022
Merged

fix: adjust config flow for amazon forwards #693

merged 2 commits into from
Jul 11, 2022

Conversation

firstof9
Copy link
Collaborator

@firstof9 firstof9 commented Jul 9, 2022

Proposed change

Adjust the amazon forwards config flow to hopefully allow empty strings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 marked this pull request as draft July 9, 2022 19:19
@firstof9 firstof9 linked an issue Jul 9, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #693 (28e65ad) into dev (c875602) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #693   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files           8        8           
  Lines        1462     1462           
=======================================
  Hits         1435     1435           
  Misses         27       27           
Impacted Files Coverage Δ
custom_components/mail_and_packages/config_flow.py 100.00% <ø> (ø)

@firstof9 firstof9 marked this pull request as ready for review July 11, 2022 18:30
@firstof9 firstof9 merged commit a49ee3e into moralmunky:dev Jul 11, 2022
@firstof9 firstof9 deleted the fix-689 branch July 11, 2022 18:31
@firstof9 firstof9 added the bugfix Pull request to fix a bug label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Error - Amazon Forwarded Email Addresses
2 participants