Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Amazon OTP password sensor #1037

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

firstof9
Copy link
Collaborator

Proposed change

Adds Amazon OTP password in a sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the feature New feature or request label Dec 19, 2024
@firstof9 firstof9 mentioned this pull request Dec 19, 2024
8 tasks
@firstof9 firstof9 marked this pull request as ready for review December 19, 2024 16:59
@firstof9 firstof9 merged commit 9972855 into moralmunky:dev Dec 19, 2024
5 checks passed
@firstof9 firstof9 deleted the new-feat-896 branch December 19, 2024 17:02
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.95%. Comparing base (8608d22) to head (ae19457).
Report is 58 commits behind head on dev.

Files with missing lines Patch % Lines
custom_components/mail_and_packages/helpers.py 88.88% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1037      +/-   ##
==========================================
- Coverage   95.07%   92.95%   -2.13%     
==========================================
  Files           8        8              
  Lines        1482     1646     +164     
==========================================
+ Hits         1409     1530     +121     
- Misses         73      116      +43     
Files with missing lines Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <100.00%> (ø)
custom_components/mail_and_packages/helpers.py 92.12% <88.88%> (-2.61%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants