Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish user properties implementation #877

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Nov 27, 2024

Release notes

Covered publish with user properties with tests and fixed publish of will messages.

What does this PR do?

Updated the creation of Will publish to include the user properties.
Also covered with tests.
Moved some test utility methods into abstract base class.

Why is it important/What is the impact to the user?

Enables the handling of user properties in PUBLISH and CONNECT Will message. All other cases of User Properties are ignored and remain unspecified.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Related issues

@andsel andsel self-assigned this Nov 27, 2024
@andsel andsel changed the title Feature/user properties tests FInish user properties implementation Nov 27, 2024
@andsel andsel force-pushed the feature/user_properties_tests branch from e3fc56a to be3e074 Compare November 27, 2024 15:36
@andsel andsel changed the title FInish user properties implementation Finish user properties implementation Nov 27, 2024
@andsel andsel merged commit c555c19 into moquette-io:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User properties implementation
1 participant