Fixed #610: Subscriptions not removed from session on unsubscribe #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
added a commit
to andsel/moquette
that referenced
this pull request
Aug 8, 2021
andsel
added a commit
that referenced
this pull request
Aug 8, 2021
andsel
pushed a commit
to andsel/moquette
that referenced
this pull request
Aug 8, 2021
andsel
added a commit
that referenced
this pull request
Aug 8, 2021
* Fixed #610: Subscriptions not removed from session on unsubscribe (#612) Co-authored-by: Hylke van der Schaaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On unsubscribe, subscriptions were not removed from Sessions and duplicate subscriptions did not replace the old subscription in the Session.
By changing Session.subscription from a List to a Set, duplicate subscriptions automatically replace old ones, and removing subscriptions becomes easier.
Also adds a Test.