Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joining Fetch #638
base: main
Are you sure you want to change the base?
Joining Fetch #638
Changes from all commits
619a6ec
4525f9d
8e1e9ca
7f19b5e
921f4c4
c285647
8fa9be8
e1093ad
1522ab7
0a00c36
e0e649e
07e93ce
d01b841
dbc9f9a
204437e
578b567
6dae36d
9fa2429
a50b040
6c0790f
eb20e67
7d4a99d
450b4d7
7db23b5
86ec7ff
094d800
5b1ec66
9cbde3c
e5a2868
d7e8648
f408e38
46f2124
6076f68
df48071
a70455e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I cancel the Subscribe, does it cancel the Fetch? I assume SUBSCRIBE_UPDATE doesn't have any impact on the Fetch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Canceling the Subscribe would not cancel the Fetch, but if you cancel the Subscribe before sending the Joining Fetch the Joining Fetch would fail with a FETCH_ERROR. SUBSCRIBE_UPDATE would only update the Subscribe with the given id, not the Fetch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. It might be worth saying "Though they share an ID, cancelling or updating the subscription has no impact on the Fetch and vice versa."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the StartGroup of the Subscribe is in the future? The current text and algorithm below seem to indicate I could issue a joining fetch for Objects that haven't been published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point I had not previously considered. We probably should preclude joining a Fetch to a Subscribe in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a pass at limiting Joining Fetch to only Subscribes with the Latest Object Filter Type. It definitely reduces the complexity here quite a bit. See a70455e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Resolved Subscribe Start Object is 0/ Subscribe FilterType is LatestGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the only case here. This can also be true if the StartObject field of a Subscribe with Filter Type of AbsoluteStart or AbsoluteRange is 0. This is an example of why I'd prefer to retain that above section defining "Resolved Subscribe..." values rather than just referring directly to the Subscribe section's definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with having the section on Resolved subscribes , but seems bit incorrect to compute those absolute values given those are filters and may not map to the exact values that we mention here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, I'm thinking of this in terms of computing an absolute value for the requested range so we can delineate which portion would be provided by a Fetch (subject to whatever limitations a standalone Fetch is subject to) and which portion would be provided by a Subscribe (subject to whatever limitations a Subscribe is subject to).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always true that if there are no Objects in the Fetch range, it results in a FETCH_ERROR, so I'm not sure we need to say it again here. If you are going to restate it, I think Fetch EndGroup == Fetch StartGroup && Fetch EndObject < Fetch StartObject also results in a FETCH_ERROR?