Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No such status as "object not available" #629

Closed
martinduke opened this issue Nov 19, 2024 · 4 comments · Fixed by #651
Closed

No such status as "object not available" #629

martinduke opened this issue Nov 19, 2024 · 4 comments · Fixed by #651
Labels
Fetch Issues related to Fetch.

Comments

@martinduke
Copy link
Contributor

martinduke commented Nov 19, 2024

In 6.7 FETCH it says

"All omitted objects have status Object Not Available."

This status doesn't exist. The closest status is "Object Does Not Exist"

I was surprised that we are sending EndOfGroup status, etc, but I can definitely live with that.

@ianswett ianswett added the Fetch Issues related to Fetch. label Jan 20, 2025
ianswett added a commit that referenced this issue Jan 20, 2025
@ianswett
Copy link
Collaborator

I sent #651 to fix this, but I'm not seeing any text that indicates we're sending EndOfGroup status.

@ianswett ianswett added Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations. and removed Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations. labels Jan 20, 2025
@martinduke
Copy link
Contributor Author

It's by implication. Object Does Not Exist is explicitly mentioned as something to omit, so by implication all other objects are included.

the FETCH section could say "all non-normal objects are omitted" but it doesn't say that.

@afrind
Copy link
Collaborator

afrind commented Jan 21, 2025

Individual Comment:

I was thinking end-of-group is useful for a fetch cache, so it can define the bounds of the group. I suppose omitting it and sending an object from a later group implicitly does the same thing though.

@martinduke
Copy link
Contributor Author

Individual Comment:

I was thinking end-of-group is useful for a fetch cache, so it can define the bounds of the group. I suppose omitting it and sending an object from a later group implicitly does the same thing though.

It might be. I haven't thought about it deeply, but we should decide how this works with intent instead of accidentally specifying it in the way we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fetch Issues related to Fetch.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants