Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ID code & Identifier validation. Updated alphanumeric regex #348

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

dmtrinh
Copy link
Contributor

@dmtrinh dmtrinh commented Oct 12, 2023

This pull request includes two items:

  • Fixed IdentificationCode and Identifier validation logic for the Originator {5000} and Beneficiary {4200} tags
  • Update to regex to include the correct special characters

What Wire specification are you referencing?
3.0.6+

What issue(s) does this pull request reference?
N/A

@dmtrinh dmtrinh requested a review from adamdecaf as a code owner October 12, 2023 08:01
@codecov-commenter
Copy link

Codecov Report

Merging #348 (9b3def2) into master (b4d8e11) will increase coverage by 0.00%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 9b3def2 differs from pull request most recent head c1bcb31. Consider uploading reports for the commit c1bcb31 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   74.83%   74.84%           
=======================================
  Files          73       73           
  Lines        8647     8649    +2     
=======================================
+ Hits         6471     6473    +2     
  Misses       1609     1609           
  Partials      567      567           

@adamdecaf adamdecaf merged commit b4470cb into moov-io:master Oct 19, 2023
@adamdecaf
Copy link
Member

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants