Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

transfers/admin: allow status change of: Pending -> Reviewable #515

Merged

Conversation

adamdecaf
Copy link
Member

We should allow the workflow of requiring a review on a pending transfer.

@adamdecaf adamdecaf added the bug Something isn't working label Jul 7, 2020
@adamdecaf adamdecaf force-pushed the transfers-pending-to-reviewable branch from 2f185bc to e18a874 Compare July 7, 2020 17:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #515 into master will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   53.46%   53.47%   +0.01%     
==========================================
  Files          97       97              
  Lines        3679     3680       +1     
==========================================
+ Hits         1967     1968       +1     
  Misses       1363     1363              
  Partials      349      349              
Impacted Files Coverage Δ
pkg/transfers/admin/approval.go 62.79% <80.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd23ce6...e18a874. Read the comment docs.

@adamdecaf adamdecaf merged commit 6815623 into moov-io:master Jul 7, 2020
@adamdecaf adamdecaf deleted the transfers-pending-to-reviewable branch July 7, 2020 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants