transfers: use banktime logic to compute EffectiveEntryDate #43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
======================================
Coverage 38.3% 38.3%
======================================
Files 14 14
Lines 1817 1817
======================================
Hits 696 696
Misses 948 948
Partials 173 173
Continue to review full report at Codecov.
|
| "traceNumber": "121042880000001", | ||
| "category": "Forward" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Don't we need a batch control for the test?
There was a problem hiding this comment.
Did you see moov-io/ach#388? It eliminates the need to include batch/file controls in the JSON. ach will try and tabulate the counts and sequence numbers then too. I hope it simplifies the API and doesn't introduce bugs. It's mentioned in the changelog, but I'm not calling it a "feature".
| } | ||
| ], | ||
| "IATBatches": null, | ||
| "fileControl": { |
There was a problem hiding this comment.
Don't we need a file control?
See: