transfers: validate amount in creation

pkg/transfers/router.go

@@ -15,6 +15,7 @@ import (
 	"github.com/moov-io/paygate/pkg/client"
 	"github.com/moov-io/paygate/pkg/customers"
 	"github.com/moov-io/paygate/pkg/customers/accounts"
+	"github.com/moov-io/paygate/pkg/model"
 	"github.com/moov-io/paygate/pkg/tenants"
 	"github.com/moov-io/paygate/pkg/transfers/fundflow"
 	"github.com/moov-io/paygate/pkg/transfers/pipeline"
@@ -144,6 +145,11 @@ func CreateUserTransfer(
 			return
 		}
 
+		if err := validateAmount(req.Amount); err != nil {
+			responder.Problem(err)
+			return
+		}
+
 		transfer := &client.Transfer{
 			TransferID:  base.ID(),
 			Amount:      req.Amount,
@@ -205,6 +211,14 @@ func CreateUserTransfer(
 	}
 }
 
+func validateAmount(raw string) error {
+	var amt model.Amount
+	if err := amt.FromString(raw); err != nil {
+		return fmt.Errorf("unable to parse '%s': %v", raw, err)
+	}
+	return nil
+}
+
 func getFundflowSource(client customers.Client, src client.Source) (fundflow.Source, error) {
 	var source fundflow.Source
 

pkg/transfers/router_test.go

@@ -151,6 +151,29 @@ func TestRouter__createUserTransfer(t *testing.T) {
 	}
 }
 
+func TestRouter__createUserTransfersInvalidAmount(t *testing.T) {
+	customersClient := mockCustomersClient()
+
+	r := mux.NewRouter()
+	router := NewRouter(log.NewNopLogger(), repoWithTransfer, tenantRepo, customersClient, mockDecryptor, mockStrategy, fakePublisher)
+	router.RegisterRoutes(r)
+
+	c := testclient.New(t, r)
+
+	opts := client.CreateTransfer{
+		Amount: "USD YY.44",
+	}
+	xfer, resp, err := c.TransfersApi.AddTransfer(context.TODO(), "userID", opts, nil)
+	if err == nil {
+		t.Error("expected error")
+	}
+	defer resp.Body.Close()
+
+	if xfer.TransferID != "" {
+		t.Errorf("unexpected transfer: %#v", xfer)
+	}
+}
+
 func TestRouter__getUserTransfer(t *testing.T) {
 	customersClient := mockCustomersClient()