Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windows tests #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enable windows tests #189

wants to merge 4 commits into from

Conversation

adamdecaf
Copy link
Member

An alternative to #188

@adamdecaf adamdecaf requested a review from atonks2 as a code owner February 14, 2024 15:40
@adamdecaf adamdecaf force-pushed the enable-windows-tests branch 14 times, most recently from 4ced1f8 to 3b28a89 Compare February 14, 2024 17:04
@adamdecaf adamdecaf force-pushed the enable-windows-tests branch 5 times, most recently from ae13e07 to c5673f5 Compare February 14, 2024 18:15
@adamdecaf adamdecaf force-pushed the enable-windows-tests branch from c5673f5 to 413484d Compare February 14, 2024 18:22
@apapsch
Copy link

apapsch commented Feb 15, 2024

I don't know why they recommended -SwitchLinuxEngine, maybe its an additional (undocumented) flag to -SwitchDaemon.

Let's try with this command:

C:\"Program Files"\Docker\Docker\DockerCli.exe -SwitchDaemon

@apapsch
Copy link

apapsch commented Feb 15, 2024

Let's forget what I said earlier. I tried DockerCli.exe on my local machine, and -SwitchLinuxEngine switches immediately to Linux containers, no restart needed.

@apapsch
Copy link

apapsch commented Feb 15, 2024

Per Github runner windows README Docker is already installed. Maybe because you install Docker via choco, this messes things up.

@adamdecaf
Copy link
Member Author

I was unable to find / run DockerCli.exe without installing Docker CE. Do you know the install path in Windows actions runners?

@adamdecaf
Copy link
Member Author

adamdecaf commented Feb 15, 2024

Linux containers seem to be the default, because when I use -SwitchDaemon there's output about using Windows containers.
https://github.com/moov-io/go-sftp/actions/runs/7905204936/job/21577274174

@adamdecaf
Copy link
Member Author

adamdecaf commented Feb 15, 2024

I've opened an issue with Github Support on why this isn't working.

I may try to publish windows/amd64 images from emberstack/docker-sftp which is already in C#. Testing against multiple servers is a good idea too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants