Pipeline chunk files benchmark #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more important to track this after adding determineMergeDestinations.
adamdecaf
force-pushed
the
pipeline-chunk-files-benchmark
branch
from
10cefe2 to
8365ce6
Compare
darwinz
reviewed
Feb 29, 2024
| @@ -60,7 +64,11 @@ func TestProcessor(t *testing.T) { | |||
|
|
|||
| require.NotNil(t, proc.HandledFile) | |||
| require.NotNil(t, proc.HandledFile.ACHFile) | |||
| require.Equal(t, "7ffdca32898fc89e5e680d0a01e9e1c2a1cd2717", proc.HandledFile.ACHFile.ID) | |||
| if runtime.GOOS == "windows" { | |||
There was a problem hiding this comment.
Interesting. Why is there a different file ID on windows?
There was a problem hiding this comment.
I'm not sure.. Maybe new Windows specific lines are throwing it off?
darwinz
approved these changes
Feb 29, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 47.70% 47.63% -0.08%
==========================================
Files 97 97
Lines 4366 4377 +11
==========================================
+ Hits 2083 2085 +2
- Misses 1952 1960 +8
- Partials 331 332 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to moov-io/ach v1.35.0 as well, which has some performance improvements.
Without the moov-io/ach upgrade this benchmark reports
After upgrading moov-io/ach
There's still a lot of room for improvement in the merge files routine, but adding Filename to
FileUploadedshouldn't hinder uploads.