Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track where pending files are merged into and report Filename on FileUploaded #226

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

adamdecaf
Copy link
Member

Fixes: #147

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 74.48980% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 47.70%. Comparing base (550964b) to head (b5494ae).

Files Patch % Lines
internal/pipeline/merging.go 75.00% 14 Missing and 3 partials ⚠️
internal/pipeline/aggregate.go 66.66% 6 Missing and 1 partial ⚠️
internal/pipeline/mock_xfer_merging.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   47.25%   47.70%   +0.45%     
==========================================
  Files          97       97              
  Lines        4313     4366      +53     
==========================================
+ Hits         2038     2083      +45     
- Misses       1945     1952       +7     
- Partials      330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf marked this pull request as ready for review February 27, 2024 22:08
@adamdecaf adamdecaf force-pushed the report-filename-in-FileUploaded branch 2 times, most recently from 71daf42 to 8e59421 Compare February 28, 2024 15:36
@adamdecaf adamdecaf force-pushed the report-filename-in-FileUploaded branch from 8e59421 to 60a4e70 Compare February 28, 2024 15:59
@adamdecaf adamdecaf merged commit dc6e821 into master Feb 28, 2024
7 checks passed
@adamdecaf adamdecaf deleted the report-filename-in-FileUploaded branch February 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline: FileUploaded events don't populate Filename
3 participants