fileHeader: allow immediate origin to be a 10 digit value #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
force-pushed
the
eduardev-master
branch
from
1f4781e to
44fea4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 111 111
Lines 6564 6564
=======================================
Hits 5696 5696
Misses 566 566
Partials 302 302 |
|
Hi guys @wadearnold @bkmoovio Can you please review this, so I can rebuild my dependencies back with moov-io? Thanks. |
wadearnold
approved these changes
Apr 16, 2019
|
Thank you @eduardev for the pull request! I wish I knew how to give you credit |
|
No worries @wadearnold, thank you for supporting oss ;) |
|
If you find a miss spelt word or anything else send a pull request. We always appreciate adding contributors. Join our slack channel if you need anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to specify a 10 digit Immediate origin value (which is the field size) rather than hardcoding a leading space.
Related: #512
Fixes: #510