Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch validation transaction code matches service class code #382

Merged

Conversation

bkmoovio
Copy link
Contributor

#56

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #382 into master will increase coverage by 0.24%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage    85.2%   85.44%   +0.24%     
==========================================
  Files         107      107              
  Lines        6684     6747      +63     
==========================================
+ Hits         5695     5765      +70     
+ Misses        712      710       -2     
+ Partials      277      272       -5
Impacted Files Coverage Δ
batcher.go 100% <ø> (ø) ⬆️
batchDNE.go 87.23% <0%> (-3.88%) ⬇️
iatBatch.go 95.36% <0%> (-0.96%) ⬇️
batchMTE.go 100% <100%> (+8%) ⬆️
batchCOR.go 100% <100%> (+6.12%) ⬆️
test/ach-ccd-write/main.go 87.23% <100%> (ø) ⬆️
test/ach-mte-write/main.go 86.95% <100%> (ø) ⬆️
batchXCK.go 100% <100%> (ø) ⬆️
batchENR.go 80.35% <100%> (+4.43%) ⬆️
batchPPD.go 100% <100%> (+9.09%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead9f0f...aeb0381. Read the comment docs.

Increase Test Code Coverage
Increase Test Coverage
Increase Test Code Coverage for batchCCD, batchCTX, batchENR, batchMTE
Increase Test Code Coverage for batchCIE and batchCOR
@bkmoovio
Copy link
Contributor Author

#56

@bkmoovio bkmoovio merged commit 6fee36a into master Nov 27, 2018
@bkmoovio bkmoovio deleted the Batch-Validation-Transaction-Code-matches-Service-Class-Code branch November 27, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants