Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xck destroyed check entry #347 #374

Merged
merged 7 commits into from
Nov 15, 2018

Conversation

bkmoovio
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ba6b60d). Click here to learn what that means.
The diff coverage is 84.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #374   +/-   ##
=========================================
  Coverage          ?   85.19%           
=========================================
  Files             ?      103           
  Lines             ?     6544           
  Branches          ?        0           
=========================================
  Hits              ?     5575           
  Misses            ?      702           
  Partials          ?      267
Impacted Files Coverage Δ
batch.go 96% <100%> (ø)
batchXCK.go 100% <100%> (ø)
test/ach-xck-read/main.go 55.55% <55.55%> (ø)
test/ach-xck-write/main.go 83.78% <83.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6b60d...fd2b777. Read the comment docs.

Copy link
Member

@wadearnold wadearnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the Changelog markdown for the unreleased version 0.4.1. Otherwise this looks perfect!

Copy link
Member

@wadearnold wadearnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request for XCK has test cases for TRC. Should those be in #373 ? Can you update the Changelog for XCK support as well?

@bkmoovio bkmoovio dismissed wadearnold’s stale review November 15, 2018 14:53

Spoke with WADE, I created XCK branch from TRC

Re-Add main_test.go
@bkmoovio bkmoovio merged commit 686e281 into master Nov 15, 2018
@bkmoovio
Copy link
Contributor Author

#347

@bkmoovio bkmoovio deleted the Support-XCK---Destroyed-Check-Entry-#347 branch November 15, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants