-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xck destroyed check entry #347 #374
Conversation
Support XCK
Add links for XCK
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=========================================
Coverage ? 85.19%
=========================================
Files ? 103
Lines ? 6544
Branches ? 0
=========================================
Hits ? 5575
Misses ? 702
Partials ? 267
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the Changelog markdown for the unreleased version 0.4.1. Otherwise this looks perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request for XCK has test cases for TRC. Should those be in #373 ? Can you update the Changelog for XCK support as well?
Update CHANGELOG for v0.4.1
Spoke with WADE, I created XCK branch from TRC
Re-Add main_test.go
#347