Support noc for iat entries #328 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# 328 Support NOC for IAT Entries
IAT code test coverage
Support NOC for IAT Entries
iatBatch update
Support_NOC-for-IAT-Entries
Increase IAT Addenda Record Code Test Coverage
Increase code test coverage for addenda18
|
Linux seems to have failed on GOVERALLS, so I restarted the build |
adamdecaf
reviewed
Oct 31, 2018
iatBatch.go
Outdated
| msg := fmt.Sprint(msgIATBatchAddendaRequired) | ||
| return &BatchError{BatchNumber: batch.Header.BatchNumber, FieldName: "Addenda16", Msg: msg} | ||
|
|
||
| if entry.Category != CategoryNOC { |
There was a problem hiding this comment.
Often for big if block like this I'll reverse the logic to return early. Then you don't have if's inside if's.
return nill for addendaFieldInclusion when entry.Category is NOC
Remove typeCode() fucntion from Addenda10-Addenda16 types as they are not Addendumer
Return nil if entry.Category = NOC
Support NOC for IAT entries
adamdecaf
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.