change parsing of Date #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badetitou
reviewed
Nov 26, 2024
| @@ -322,7 +322,7 @@ GitMetricExporter >> findParticipationOfCommitAuthorNamed: username amongProject | |||
| response := glhImporter repoApi | |||
| commitsOfUser: username | |||
| inProject: project id | |||
| since: '01 january 2023' asDateAndTime | |||
| since: '01 january 2023' asDate asDateAndTime | |||
badetitou
reviewed
Nov 26, 2024
| @@ -433,7 +433,7 @@ GitMetricExporter >> initialize [ | |||
|
|
|||
| entities := OrderedCollection new. | |||
| "set up the minimal date from which we are looking for the commits a particular user in projects" | |||
| sinceTimeLimit := '2024-01-01' asDateAndTime. | |||
| sinceTimeLimit := '2024-01-01' asDate asDateAndTime. | |||
badetitou
reviewed
Nov 26, 2024
| @@ -35,7 +34,7 @@ GLPHModelImporter >> commitsOfProject: aGLHProject forRefName: refName until: to | |||
| newlyFoundCommit := parsedResults reject: [ :commitParsed | | |||
| (toDate isNil or: [ | |||
| commitParsed committed_date | |||
| < toDate asDateAndTime ]) or: [ | |||
| < toDate asDate asDateAndTime ]) or: [ | |||
badetitou
reviewed
Nov 26, 2024
| @@ -277,9 +276,9 @@ GLPHModelImporter >> importMergeRequests: aGLHProject since: fromDate until: toD | |||
| results := self repoApi | |||
| mergeRequestsOfProject: aGLHProject id | |||
| createdAfter: | |||
| (fromDate ifNotNil: [ fromDate asDateAndTime asString ]) | |||
| (fromDate ifNotNil: [ fromDate asDate asDateAndTime asString ]) | |||
| createdBefore: | |||
badetitou
reviewed
Nov 26, 2024
| @@ -427,5 +426,5 @@ GLPHModelImporter >> withCommitsSince: someDays [ | |||
| (someDays isKindOf: DateAndTime) | |||
| ifTrue: [ withCommitsSince := someDays ] | |||
| ifFalse: [ | |||
| withCommitsSince := (Date today - someDays) asDateAndTime ] | |||
| withCommitsSince := (Date today - someDays) asDate asDateAndTime ] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.